[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=410848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410848
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 05:28
Start Date: 27/Mar/20 05:28
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #11246:
[BEAM-9136]Add licenses for dependencies for Go
URL: https://github.com/apache/beam/pull/11246#discussion_r399042837
##########
File path: sdks/go/container/license_script.sh
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+output_dir=third_party_licenses
+# remove output_dir if existing
+if [ -d "$output_dir" ]; then rm -rf $output_dir; fi
+
+# get go-licenses and run
+go get github.com/google/go-licenses
+$GOPATH/bin/go-licenses save "github.com/apache/beam/sdks/go/pkg/beam/"
--save_path="$output_dir"
Review comment:
This line returns `not found` error when run with Jenkins. When I test with
my machine, `$GOPATH/bin/go-license` worked.
I tried with `go-licenses`, `$GOPATH/bin/go-license`,
`/usr/bin/go/bin/go-licenses` but no one worked. All returned `not found`
error.
[log](https://builds.apache.org/job/beam_PreCommit_Go_Commit/6020/console)
How do we run a Go package within Jenkins? Can we use the same script to run
both locally and Jenkins? And in case users want to customize it, it should be
able to run at users' machine as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 410848)
Time Spent: 8h 40m (was: 8.5h)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
