[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=411602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411602
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/20 04:00
Start Date: 28/Mar/20 04:00
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #11246:
[BEAM-9136]Add licenses for dependencies for Go
URL: https://github.com/apache/beam/pull/11246#discussion_r399615711
##########
File path: sdks/go/container/license_script.sh
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+output_dir=third_party_licenses
+# remove output_dir if existing
+if [ -d "$output_dir" ]; then rm -rf $output_dir; fi
+
+# get go-licenses and run
+go get github.com/google/go-licenses
+$GOPATH/bin/go-licenses save "github.com/apache/beam/sdks/go/pkg/beam/"
--save_path="$output_dir"
Review comment:
The Go SDK isn't currently up on all the best practices for Go. In
particular, what you're running on your machine is probably not what Jenkin's
is pulling down due to how versioning isn't being handled at present. It's not
currently a priority to spend effort to resolve this state of affairs. It will
not happen until after SDF and Beam Schema's have been added to the SDK later
this year.
I do not recommend spending time *now* to do this, but please keep
sufficient notes so that we can resolve the Go situation later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411602)
Time Spent: 10h 20m (was: 10h 10m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
