[
https://issues.apache.org/jira/browse/BEAM-9608?focusedWorklogId=411449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411449
]
ASF GitHub Bot logged work on BEAM-9608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 22:43
Start Date: 27/Mar/20 22:43
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #11229: [BEAM-9608]
Increasing scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r399570655
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -415,24 +412,24 @@ def _run_bundle_multiple_times_for_testing(
cache_token_generator=cache_token_generator)
testing_bundle_manager.process_bundle(data_input, data_output)
finally:
- worker_handler.state.restore()
+
runner_execution_context.worker_handler_manager.state_servicer.restore()
def _collect_written_timers_and_add_to_deferred_inputs(
self,
- pipeline_components, # type: beam_runner_api_pb2.Components
- stage, # type: translations.Stage
+ runner_execution_context, # type: execution.FnApiRunnerExecutionContext
bundle_context_manager, # type: execution.BundleContextManager
deferred_inputs, # type: MutableMapping[str, PartitionableBuffer]
- data_channel_coders, # type: Mapping[str, str]
):
# type: (...) -> None
- for transform_id, timer_writes in stage.timer_pcollections:
+ for transform_id, timer_writes in \
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411449)
Time Spent: 2h 20m (was: 2h 10m)
> Add context managers for FnApiRunner to manage execution of each bundle
> -----------------------------------------------------------------------
>
> Key: BEAM-9608
> URL: https://issues.apache.org/jira/browse/BEAM-9608
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
