[
https://issues.apache.org/jira/browse/BEAM-9608?focusedWorklogId=414220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414220
]
ASF GitHub Bot logged work on BEAM-9608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 18:45
Start Date: 01/Apr/20 18:45
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11229: [BEAM-9608]
Increasing scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r401828861
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -511,87 +509,32 @@ def _add_residuals_and_channel_splits_to_deferred_inputs(
def _run_stage(self,
runner_execution_context, # type:
execution.FnApiRunnerExecutionContext
- stage, # type: translations.Stage
+ bundle_context_manager, # type:
execution.BundleContextManager
Review comment:
It's odd that _run_stage no longer takes as a parameter the stage to run.
Perhaps bundle_context_manager (and its class?) should be named stage_context
or similar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414220)
Time Spent: 3h (was: 2h 50m)
> Add context managers for FnApiRunner to manage execution of each bundle
> -----------------------------------------------------------------------
>
> Key: BEAM-9608
> URL: https://issues.apache.org/jira/browse/BEAM-9608
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
