[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=411546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411546
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/20 00:22
Start Date: 28/Mar/20 00:22
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199:
[BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r399587568
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
##########
@@ -197,7 +199,7 @@ public boolean canTranslate(PTransform<?, ?> pTransform) {
((KvCoder) mainInput.getCoder()).getKeyCoder(),
// TODO: Add support for timer payloads to the SDK
// We currently assume that all payloads are unspecified.
- Timer.Coder.of(VoidCoder.of())));
+ Timer.Coder.of(StringUtf8Coder.of(),
GlobalWindow.Coder.INSTANCE)));
Review comment:
```suggestion
Timer.Coder.of(((KvCoder)
mainInput.getCoder()).getKeyCoder(), GlobalWindow.Coder.INSTANCE)));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411546)
Time Spent: 5h 50m (was: 5h 40m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
