[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=411553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411553
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/20 00:22
Start Date: 28/Mar/20 00:22
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199:
[BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r399588611
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Timer.java
##########
@@ -40,14 +49,26 @@
@AutoValue
public abstract class Timer<T> {
- /** Returns a timer for the given timestamp with a {@code null} payload. */
- public static Timer<Void> of(Instant time) {
- return of(time, (Void) null);
+ /**
+ * Returns a timer for the given timestamp with a user specified payload.
+ *
+ * @return
+ */
+ // TODO(BEAM-9562): Plumb through actual Timer fields.
+ public static <T> Timer<T> of(
Review comment:
May I suggest you create these two static methods for creating the two
common cases?
.of(userKey, dynamicTimerTag, fireTimestamp, holdTimestamp, windows, pane);
.cleared(userKey, dynamicTImerTag);
this way you can make sure that dynamicTimerTag, fireTimestamp,
holdTimestamp, windows and pane are not null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411553)
Time Spent: 6h 10m (was: 6h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
