[
https://issues.apache.org/jira/browse/BEAM-9578?focusedWorklogId=415873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415873
]
ASF GitHub Bot logged work on BEAM-9578:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/20 01:31
Start Date: 04/Apr/20 01:31
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11205: [BEAM-9578]
Enumerating artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r403403766
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1206,6 +1210,15 @@ message MavenPayload {
string repository_url = 2;
}
+message DeferredArtifactPayload {
+ // A unique string identifier assigned by the creator of this payload. The
creator may use this key to confirm
+ // whether they can parse the data.
+ string key = 1;
Review comment:
Should this be uid? Any collisions here could be bad...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415873)
Time Spent: 6h (was: 5h 50m)
> Enumerating artifacts is too expensive in Java
> ----------------------------------------------
>
> Key: BEAM-9578
> URL: https://issues.apache.org/jira/browse/BEAM-9578
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Heejong Lee
> Priority: Critical
> Labels: portability
> Fix For: 2.21.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> There are a lot of places (e.g. *ParDoTranslation#getParDoPayload*) which
> effectively call *Environments#createOrGetDefaultEnvironment* which causes
> [artifacts to be
> computed|https://github.com/apache/beam/blob/fc6cef9972780ca6b7525d4aadd65a8344221f1b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java#L114].
> This leads to zipping directories for non-jar dependencies.
> Similar problems may exist for Python/Go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
