[
https://issues.apache.org/jira/browse/BEAM-9578?focusedWorklogId=415875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415875
]
ASF GitHub Bot logged work on BEAM-9578:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/20 01:31
Start Date: 04/Apr/20 01:31
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11205: [BEAM-9578]
Enumerating artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r403403332
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/DefaultArtifactResolver.java
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.core.construction;
+
+import java.util.List;
+import java.util.Map;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.apache.beam.model.pipeline.v1.RunnerApi;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap;
+import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Lists;
+
+/**
+ * A default artifact resolver. This resolver applies {@link ResolutionFn} in
the reversed order
+ * they registered i.e. the function registered later overrides the earlier
one if they resolve the
+ * same artifact.
+ */
+public class DefaultArtifactResolver implements ArtifactResolver {
+ public static final ArtifactResolver INSTANCE = new
DefaultArtifactResolver();
+
+ private List<ResolutionFn> fns =
+ Lists.newArrayList(
+ (info) -> {
+ if
(BeamUrns.getUrn(RunnerApi.StandardArtifacts.Types.FILE).equals(info.getTypeUrn()))
{
+ return ImmutableList.of(info);
+ } else {
+ return ImmutableList.of();
Review comment:
Is the empty list special? In particular sometimes a deferred artifact may
resolve to nothing, which is different than not being able to be resolved... I
think we still need optional or null or an exception to denote unresolveable by
this resolver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415875)
Time Spent: 6h (was: 5h 50m)
> Enumerating artifacts is too expensive in Java
> ----------------------------------------------
>
> Key: BEAM-9578
> URL: https://issues.apache.org/jira/browse/BEAM-9578
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Heejong Lee
> Priority: Critical
> Labels: portability
> Fix For: 2.21.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> There are a lot of places (e.g. *ParDoTranslation#getParDoPayload*) which
> effectively call *Environments#createOrGetDefaultEnvironment* which causes
> [artifacts to be
> computed|https://github.com/apache/beam/blob/fc6cef9972780ca6b7525d4aadd65a8344221f1b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java#L114].
> This leads to zipping directories for non-jar dependencies.
> Similar problems may exist for Python/Go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
