[ https://issues.apache.org/jira/browse/BEAM-9977?focusedWorklogId=440903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440903 ]
ASF GitHub Bot logged work on BEAM-9977: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Jun/20 17:46 Start Date: 03/Jun/20 17:46 Worklog Time Spent: 10m Work Description: boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r434745710 ########## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ########## @@ -906,19 +955,110 @@ public void setValueDeserializer(String valueDeserializer) { Coder<K> keyCoder = getKeyCoder(coderRegistry); Coder<V> valueCoder = getValueCoder(coderRegistry); - // Handles unbounded source to bounded conversion if maxNumRecords or maxReadTime is set. - Unbounded<KafkaRecord<K, V>> unbounded = - org.apache.beam.sdk.io.Read.from( - toBuilder().setKeyCoder(keyCoder).setValueCoder(valueCoder).build().makeSource()); + if (!isUseSDFTransform() + || !ExperimentalOptions.hasExperiment(input.getPipeline().getOptions(), "beam_fn_api") Review comment: SDF is only supported over `beam_fn_api`. We shouldn't expand the `KafkaIO.Read` with SDF when the `beam_fn_api` is not enbaled, or `beam_fn_api_use_deprecated_read ` is enabled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 440903) Time Spent: 8h 10m (was: 8h) > Build Kafka Read on top of Java SplittableDoFn > ---------------------------------------------- > > Key: BEAM-9977 > URL: https://issues.apache.org/jira/browse/BEAM-9977 > Project: Beam > Issue Type: New Feature > Components: io-java-kafka > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: P2 > Time Spent: 8h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)