[
https://issues.apache.org/jira/browse/BEAM-9977?focusedWorklogId=441005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441005
]
ASF GitHub Bot logged work on BEAM-9977:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/20 22:23
Start Date: 03/Jun/20 22:23
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434890835
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -817,6 +847,24 @@ public void setValueDeserializer(String valueDeserializer)
{
return toBuilder().setCommitOffsetsInFinalizeEnabled(true).build();
}
+ /**
+ * The {@link Read} transform will be expanded with {@link
ReadFromKafkaViaSDF} transform. While
+ * working with {@link #useSDFTransformInRead()} and {@link
+ * #withTimestampPolicyFactory(TimestampPolicyFactory)} together, only
{@link
+ * TimestampPolicyFactory#withCreateTime(Duration)}, {@link
+ * TimestampPolicyFactory#withLogAppendTime()} and {@link
+ * TimestampPolicyFactory#withProcessingTime()} will be populated
correctly. For other custom
+ * {@link TimestampPolicy}, the transform will use {@link
+ * TimestampPolicyFactory#withProcessingTime()} by default. It's
recommended to use {@link
+ * ReadFromKafkaViaSDF} directly in that case.
+ *
+ * <p>Note that the expansion only happens when tbe pipeline has
"beam_fn_api" experiment and
+ * meanwhile "beam_fn_api_use_deprecated_read" is not set.
+ */
+ public Read<K, V> useSDFTransformInRead() {
Review comment:
Discussed with Luke offline. We think it would be better to make
`KafkaIO.Read()` expand with SDF transform bu default when `beam_fn_api` is
enabled( before introducing this SDF transform, we expand the `Read` with
SDFUnboundedWrapper with beam_fn_api).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 441005)
Time Spent: 8h 50m (was: 8h 40m)
> Build Kafka Read on top of Java SplittableDoFn
> ----------------------------------------------
>
> Key: BEAM-9977
> URL: https://issues.apache.org/jira/browse/BEAM-9977
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
