ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172257226
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java ########## @@ -110,11 +150,15 @@ public long getFileChannelPosition() { * @throws IOException if the write or sync operation fails. */ public void flush(boolean shouldForceWrite) throws IOException { + flush(shouldForceWrite, false); + } + + public void flush(boolean shouldForceWrite, boolean forceMetadata) throws IOException { synchronized (this) { Review comment: Looking at flushInternal(), that method should be synchronized. I would synchronize flushInternal, and rename it to flush(), then kill these two methods completely. Where they are being called, if the user wants to force, they should call forceWrite directly (should probably be renamed force too). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services