ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172312290
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java ########## @@ -110,11 +150,15 @@ public long getFileChannelPosition() { * @throws IOException if the write or sync operation fails. */ public void flush(boolean shouldForceWrite) throws IOException { + flush(shouldForceWrite, false); + } + + public void flush(boolean shouldForceWrite, boolean forceMetadata) throws IOException { synchronized (this) { Review comment: I'm strongly -1 on adding another boolean parameter to this method. You're modifying now, so now is the time to do it cleanly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services