sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176331262
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -116,6 +121,18 @@ public ConcurrentLongLongHashMap getLedgersMap() {
return entryLogMetadata.getLedgersMap();
}
+ public boolean isLedgerDirFull() {
Review comment:
it seems that you are converting this class to inner class just because you
want to reference ledgerDirsManager. I don't think this is a good change.
I would prefer not reference `ledgerDirManager`. you should just add
`getFile()` in this class and call
`ledgerDirsManager.isDirFull(channel.getFile())`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
