sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176336059
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ########## @@ -802,88 +864,207 @@ private long readLastLogId(File f) { } } + interface EntryLogManager { + /* + * acquire lock for this ledger. + */ + void acquireLock(Long ledgerId); Review comment: Can we try to hide these locking stuffs? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services