reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180010398
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java
##########
@@ -54,7 +49,7 @@ protected boolean removeEntryLog(long entryLogId) {
}
@Override
- public synchronized long addEntry(long ledger, ByteBuffer entry) throws
IOException {
+ public synchronized long addEntry(Long ledgerId, ByteBuffer entry) throws
IOException {
Review comment:
in EntryLogManagerForEntryLogPerLedger I maintain couple of datastructures,
where key for HashMap is ledgerId and hence Long wrapper class is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
