reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180010928
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java
##########
@@ -100,9 +104,9 @@ public void testCreateNewLog() throws Exception {
EntryLogger el = new EntryLogger(conf, ledgerDirsManager);
// Calls createNewLog, and with the number of directories we
// are using, if it picks one at random it will fail.
- el.createNewLog();
- LOG.info("This is the current log id: " + el.getCurrentLogId());
- assertTrue("Wrong log id", el.getCurrentLogId() > 1);
+ el.createNewLog(0L);
+ LOG.info("This is the current log id: " +
el.getPreviousAllocatedEntryLogId());
Review comment:
in all these places i considered whether preallocation is enabled or not
appropriately and getPrevisousAllocatedEntryLogId is the appropriate one to
validate the cases here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
