[ 
https://issues.apache.org/jira/browse/CALCITE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122230#comment-15122230
 ] 

Julian Hyde commented on CALCITE-642:
-------------------------------------

Very nice work. A few things:
* Change the commit description to make clear you're adding to Avatica 
*server*. We don't need dependency bloat in the client.
* Move the version number in pom.xml into the properties list (consistent with 
what I did in CALCITE-999)
* Add a small section to http://calcite.apache.org/docs/avatica_overview.html 
and add the package to the "structure" section

I ran the extended test suite, and everything looks great. So +1 to commit when 
you've fixed the above.

> Avatica server metrics
> ----------------------
>
>                 Key: CALCITE-642
>                 URL: https://issues.apache.org/jira/browse/CALCITE-642
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>              Labels: avatica
>             Fix For: next
>
>
> Along the same lines as CALCITE-641, avatica server should track some basic 
> metrics. We can expose them through a "standard" API (such as Hadoop metrics, 
> or Dropwizard metrics), and include them on some interval in the service log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to