[
https://issues.apache.org/jira/browse/CALCITE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131405#comment-15131405
]
Julian Hyde commented on CALCITE-642:
-------------------------------------
Looks great. It must have taken a lot of effort to clone the dropwizard API and
produce an implementation of it - kudos.
Some really minor stuff:
* Do we need avatica-metrics-dropwizardmetrics3/.gitignore?
* Do we need any of those log4j.properties files? A bad log4j.properties crept
onto my classpath recently and was burning masses of CPU. I had to nuke my
sandbox.
* services/org.apache.calcite.avatica.metrics.MetricsSystemFactory has no
newline at end of file
* We now use properties for version numbers in POMs
* I didn't know you could remove version number from a pom.xml and inherit it
from the parent
* You could make Timer.Context implement Closeable (Dropwizard's Context does)
or AutoCloseable, then try-with-resources will call stop automatically
I'm running full regress on f9ccaa6 now.
> Avatica server metrics
> ----------------------
>
> Key: CALCITE-642
> URL: https://issues.apache.org/jira/browse/CALCITE-642
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Labels: avatica
> Fix For: next
>
>
> Along the same lines as CALCITE-641, avatica server should track some basic
> metrics. We can expose them through a "standard" API (such as Hadoop metrics,
> or Dropwizard metrics), and include them on some interval in the service log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
