[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289546#comment-15289546 ]
Julian Hyde commented on CALCITE-1241: -------------------------------------- It makes sense, and the patch looks good. But I wonder, could we go further? Are there any pitfalls that people run into every time they add a keyword, and is there something we could do to make that easier? > Add a freemarker variable for adding non reserved keywords to Parser.jj > template > -------------------------------------------------------------------------------- > > Key: CALCITE-1241 > URL: https://issues.apache.org/jira/browse/CALCITE-1241 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Venki Korukanti > Assignee: Julian Hyde > > Currently Calcite parser allows customizing parser grammar for supporting new > Sql constructs (ex. {{SHOW TABLES}} or {{CREATE TABLE ... AS QUERY}}) through > freemarker template variables. There is a freemarker template variable to > allow new keywords, but all these keywords are added as reserved keywords > which are not allowed as identifiers unless escaped with {{`}} (or configured > casing character). > This JIRA is to add a freemarker template variable for adding non reserved > keywords list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)