[
https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289896#comment-15289896
]
Julian Hyde commented on CALCITE-1241:
--------------------------------------
Yes, please add a test to SqlParserTest as part of the patch. Call
{{getJdbcKeywords}} (as in testMetadata), split on commas, remove non-reserved
keywords, and you have the list of reserved keywords. Compare that with a list
hard-coded in the test.
Drill should consider calling SqlParserTest from within its test suite (one or
two tests might need to be overridden or disabled, but it would still provide
useful information). But anyway that is definitely part of this task.
> Add a freemarker variable for adding non reserved keywords to Parser.jj
> template
> --------------------------------------------------------------------------------
>
> Key: CALCITE-1241
> URL: https://issues.apache.org/jira/browse/CALCITE-1241
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Venki Korukanti
> Assignee: Julian Hyde
> Fix For: 1.8.0
>
>
> Currently Calcite parser allows customizing parser grammar for supporting new
> Sql constructs (ex. {{SHOW TABLES}} or {{CREATE TABLE ... AS QUERY}}) through
> freemarker template variables. There is a freemarker template variable to
> allow new keywords, but all these keywords are added as reserved keywords
> which are not allowed as identifiers unless escaped with {{`}} (or configured
> casing character).
> This JIRA is to add a freemarker template variable for adding non reserved
> keywords list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
