[ 
https://issues.apache.org/jira/browse/CALCITE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398281#comment-15398281
 ] 

Julian Hyde commented on CALCITE-1333:
--------------------------------------

Is this a duplicate of CALCITE-1043? Can you build on the patch for that case? 
(I reviewed the patch as "basically good" but never heard back from [~tedxu].)

> AggFunctions supported by JdbcAggregate should depend on SqlKind, instead of 
> operator instance
> ----------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1333
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1333
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: MinJi Kim
>            Assignee: Julian Hyde
>
> In JdbcAggregate, there is a list of functions that can be implemented and 
> therefore pushed into the underlying database.  The list of functions uses 
> operator instance, but it would be better to use SqlKind.  This is 
> particularly relevant in case a user creates his own operators (e.g. Drill 
> wraps some of calcite's operators), so comparing instances will not work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to