[ 
https://issues.apache.org/jira/browse/CALCITE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398417#comment-15398417
 ] 

MinJi Kim commented on CALCITE-1333:
------------------------------------

[~julianhyde] I looked through CALCITE-1043.  It looks like patch for 
CALCITE-1200 (by [~venki387]) already made most of the changes in the patch for 
CALCITE-1043.  I pulled in the missing pieces and updated the pull request, 
https://github.com/apache/calcite/pull/262.  

> AggFunctions supported by JdbcAggregate should depend on SqlKind, instead of 
> operator instance
> ----------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1333
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1333
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: MinJi Kim
>            Assignee: Julian Hyde
>
> In JdbcAggregate, there is a list of functions that can be implemented and 
> therefore pushed into the underlying database.  The list of functions uses 
> operator instance, but it would be better to use SqlKind.  This is 
> particularly relevant in case a user creates his own operators (e.g. Drill 
> wraps some of calcite's operators), so comparing instances will not work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to