[ 
https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149174#comment-16149174
 ] 

Chris Baynes commented on CALCITE-1940:
---------------------------------------

I tried this out with postgres and noticed a problem - postgres (unlike other 
dbs) already returns a list of sequences in the jdbc metadata. So the table map 
building fails because of duplicates. It probably makes sense to just always 
skip {{SEQUENCE}} and {{TEMPORARY_SEQUENCE}} in the loop, and only get them 
from the dialect sequence information.

I can't really comment right now on your dialect handling improvement, since 
I'm still not sure why the dialect handling here needs something different than 
what already exists. The dialect handlers are already able to push-down calls 
to different dbs as long as the planner finds the right plan.

> Implement dialect specific support for sequences
> ------------------------------------------------
>
>                 Key: CALCITE-1940
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1940
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Christian Beikov
>            Assignee: Julian Hyde
>
> The Calcite parser and validator already supports sequences but the push down 
> to the JDBC level is currently limited. SInce sequences are not supported on 
> all DBMS every sql dialect should have the possibility to render it's own way 
> of extracting sequence information or incrementing the value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to