[
https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156012#comment-16156012
]
Julian Hyde commented on CALCITE-1940:
--------------------------------------
I see you have (a) created a sub-class of SqlDialect per database product, (b)
deprecated DatabaseProduct. Can you explain the benefit of this? The current
code is more concise and, in my opinion, better. Virtual methods are not the
only way to override behavior; what Scala calls "case classes" are another
approach, and at present we use a blend of the two, which I think is ideal.
I support the creation of "handlers" to extend/modify the capabilities of
SqlDialect objects. And that means we will have to change how SqlDialect is
instantiated.
> Implement dialect specific support for sequences
> ------------------------------------------------
>
> Key: CALCITE-1940
> URL: https://issues.apache.org/jira/browse/CALCITE-1940
> Project: Calcite
> Issue Type: Improvement
> Reporter: Christian Beikov
> Assignee: Julian Hyde
>
> The Calcite parser and validator already supports sequences but the push down
> to the JDBC level is currently limited. SInce sequences are not supported on
> all DBMS every sql dialect should have the possibility to render it's own way
> of extracting sequence information or incrementing the value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
