[ 
https://issues.apache.org/jira/browse/CALCITE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408318#comment-16408318
 ] 

ASF GitHub Bot commented on CALCITE-2219:
-----------------------------------------

Github user laurentgo commented on the issue:

    https://github.com/apache/calcite-avatica/pull/33
  
    Not really triggered by a bug, but more by the extra code in Drill and 
Dremio JDBC drivers to implements the JDBC spec. Let me see if can reuse the 
same strategy as the Drill code (helper class to iterate over methods and check 
that the methods throws the correct exception).
    
    There are also lots of methods where unsupported is thrown instead of a 
sqlexception for closed. I wonder if the correct thing to do would be to check 
first for closed, and then throw unsupported, and if it's fine for now.


> Avatica Connection/Statement/ResultSet don't throw if resource is closed
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-2219
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2219
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Major
>
> According to JDBC spec/Javadoc, almost all methods of 
> {{Connection}}/{{Statement}}/{{PreparedStatement}}/{{ResultSet}} should throw 
> an exception if resource is closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to