[
https://issues.apache.org/jira/browse/CALCITE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408341#comment-16408341
]
ASF GitHub Bot commented on CALCITE-2219:
-----------------------------------------
Github user joshelser commented on the issue:
https://github.com/apache/calcite-avatica/pull/33
> Not really triggered by a bug, but more by the extra code in Drill and
Dremio JDBC drivers to implements the JDBC spec. Let me see if can reuse the
same strategy as the Drill code (helper class to iterate over methods and check
that the methods throws the correct exception).
Ok. I definitely didn't want to suggest that you try to cover every single
one of these methods you fixed up :). I like to see at least one test added
when we fix straighforward bugs like this, even if it is known that we're only
catching one case. Appreciate you looking into it!
> Avatica Connection/Statement/ResultSet don't throw if resource is closed
> ------------------------------------------------------------------------
>
> Key: CALCITE-2219
> URL: https://issues.apache.org/jira/browse/CALCITE-2219
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Major
>
> According to JDBC spec/Javadoc, almost all methods of
> {{Connection}}/{{Statement}}/{{PreparedStatement}}/{{ResultSet}} should throw
> an exception if resource is closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
