[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498429#comment-16498429 ]
ASF GitHub Bot commented on CALCITE-2322: ----------------------------------------- Github user kminder commented on a diff in the pull request: https://github.com/apache/calcite-avatica/pull/49#discussion_r192492050 --- Diff: core/src/main/java/org/apache/calcite/avatica/BuiltInConnectionProperty.java --- @@ -77,7 +77,10 @@ TRUSTSTORE_PASSWORD("truststore_password", Type.STRING, null, false), HOSTNAME_VERIFICATION("hostname_verification", Type.ENUM, HostnameVerification.STRICT, - HostnameVerification.class, false); + HostnameVerification.class, false), + + /** Fetch size limit, default is 100 rows. */ + FETCH_SIZE("fetch_size", Type.NUMBER, AvaticaStatement.DEFAULT_FETCH_SIZE, false); --- End diff -- I'm not clear on your suggestion. Are you suggesting that the url connection parameter be named "DEFAULT_FETCH_SIZE" or as you suggest above "defaultFetchSize". You mention having looked at a few other drivers I've looked too and don't see much consistency. I chose "fetch_size" because that seemed consistent with the other parameters. Would "default_fetch_size" be agreeable? > Add fetch size support to connection url and JDBC statement > ----------------------------------------------------------- > > Key: CALCITE-2322 > URL: https://issues.apache.org/jira/browse/CALCITE-2322 > Project: Calcite > Issue Type: Improvement > Components: core > Affects Versions: 1.11.0 > Reporter: Kevin Minder > Assignee: Julian Hyde > Priority: Major > > Currently the remote driver defaults to hard coded fetch size of 100 rows. > When a connection is operating in HTTP mode having such a small fetch size > can add enormous overhead. This is especially true if TLS connections are > used and made worse if each connection flows throw multiple proxies. > Consider that 100K rows returned 100 rows at a time will make 1K HTTP POST > requests. One might say that nobody should ever do that but some tools like > Spotfire may end up doing this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)