[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096896#comment-17096896
 ] 

Julian Hyde commented on CALCITE-2970:
--------------------------------------

The other reason, besides handling sub-classes of {{RelBuilder}}, to use a 
{{UnaryOperator<RelBuilder}}> is that you can start from an existing 
{{RelBuilder}} that has some properties and state. Other suggestions that have 
been made - using a {{RelBuilderFactory}} or a {{RelBuilder.Config}} - have 
cases where they lose information. (E.g. the current {{RelOptCluster}}, which 
is in the {{RelBuilder}} but not its {{Config}}, or the current 
{{ViewExpander}}, which comes from the {{Context}} but not the {{Config}}.)

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 18h 20m
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to