[ 
https://issues.apache.org/jira/browse/CALCITE-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349444#comment-17349444
 ] 

Julian Hyde commented on CALCITE-4617:
--------------------------------------

No question that there's a bug here, and the PR fixes one case of the bug. But 
whoever reviews this PR needs to think through the cases where the join has a 
selectivity exactly one, less than one, more than one. More test cases may be 
needed.

> Wrong offset when SortJoinTransposeRule pushes a sort node with an offset
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-4617
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4617
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: Sylvain Crozon
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The SortJoinTransposeRule will push a sort node past a join, and then 
> duplicate the sort node on top of the join. When the sort node has an offset, 
> we should only apply it once, otherwise we end up skipping twice as many rows 
> as we should. The sort node added on top of the join should have a null 
> offset.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to