[ https://issues.apache.org/jira/browse/CALCITE-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350926#comment-17350926 ]
Ruben Q L commented on CALCITE-4617: ------------------------------------ BTW, I just found an old (related?) ticket that was supposed to deal with offset issues in SortJoinTransposeRule: CALCITE-1507 {code} // 3) If sort has an offset, and if the non-preserved side // of the join is not count-preserving against the join // condition, we bail out {code} [~sylvaincrozon], [~julianhyde] do you think that patch was wrong / incomplete? It seems the current PR is "fixing" precisely one of the tests (testSortJoinTranspose6) added by CALCITE-1507. Should we focus on fixing CALCITE-1507's logic (if it needs to be fixed) rather than just using {{null}} offset? Also, notice that there is another test added by CALCITE-1507 (testSortJoinTranspose7) that verifies that OFFSET is cannot be pushed (and the rule is not applied). > Wrong offset when SortJoinTransposeRule pushes a sort node with an offset > ------------------------------------------------------------------------- > > Key: CALCITE-4617 > URL: https://issues.apache.org/jira/browse/CALCITE-4617 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.26.0 > Reporter: Sylvain Crozon > Assignee: Ruben Q L > Priority: Major > Labels: pull-request-available > Fix For: 1.27.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The SortJoinTransposeRule will push a sort node past a join, and then > duplicate the sort node on top of the join. When the sort node has an offset, > we should only apply it once, otherwise we end up skipping twice as many rows > as we should. The sort node added on top of the join should have a null > offset. > > For example the testSortJoinTranspose6 test checks that for this initial plan > {code} > LogicalProject(DEPTNO=[$0], EMPNO=[$2]) > LogicalSort(offset=[2], fetch=[10]) > LogicalJoin(condition=[=($0, $9)], joinType=[right]) > LogicalTableScan(table=[[CATALOG, SALES, DEPT]]) > LogicalTableScan(table=[[CATALOG, SALES, EMP]]) > {code} > the SortJoinTransposeRule should convert to > {code} > LogicalProject(DEPTNO=[$0], EMPNO=[$2]) > LogicalSort(offset=[2], fetch=[10]) > LogicalJoin(condition=[=($0, $9)], joinType=[right]) > LogicalTableScan(table=[[CATALOG, SALES, DEPT]]) > LogicalSort(offset=[2], fetch=[10]) > LogicalTableScan(table=[[CATALOG, SALES, EMP]]) > {code} > Which will result in applying the offset twice. Instead the LogicalSort on > top of the join should just have a null offset -- This message was sent by Atlassian Jira (v8.3.4#803005)