[
https://issues.apache.org/jira/browse/CALCITE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681535#comment-17681535
]
Alessandro Solimando commented on CALCITE-5501:
-----------------------------------------------
>From your description I think you are referring to CALCITE-3517.
I think that even writing the file once per test class, we would still be
having a race condition, because one of the two test classes might be writing
when the other one is comparing.
Of course it would limit sensibly the chances of the race condition to happen
(once per class vs once per test) but we would still need a lock on
_SqlToRelConverterTest.xml_ which remains shared, so I think that my propose
patch would still be needed.
I therefore suggest to get this in (once the release is over) and tackle the
performance improvement separately as part of CALCITE-3517, if that makes sense
to you too.
> SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in
> Jenkins CI
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-5501
> URL: https://issues.apache.org/jira/browse/CALCITE-5501
> Project: Calcite
> Issue Type: Bug
> Components: tests
> Affects Versions: 1.32.0
> Reporter: Stamatis Zampetakis
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Sample runs that failed due to
> SqlToRelConverterTest.checkActualAndReferenceFiles:
> *
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/15/console
> *
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/18/console
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
