[ 
https://issues.apache.org/jira/browse/CALCITE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687461#comment-17687461
 ] 

Alessandro Solimando commented on CALCITE-5501:
-----------------------------------------------

I think that will help with CALCITE-3517, but the issue we have here would 
still exist, since each test (and associated golden file) would still be 
shared. As I was saying in a previous comment, the race condition will be rarer 
but still happening if the same test is executed at the same time by both 
classes.

This said I think it might be a good improvement and worth trying, since these 
kind of tests are widespread and time consuming, so if it helps with 
CALCITE-3517 we will make our tests run way faster!

> SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in 
> Jenkins CI
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5501
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5501
>             Project: Calcite
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 1.32.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Alessandro Solimando
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.34.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Sample runs that failed due to 
> SqlToRelConverterTest.checkActualAndReferenceFiles:
> * 
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/15/console
> * 
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/18/console
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to