[ 
https://issues.apache.org/jira/browse/CALCITE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696712#comment-17696712
 ] 

Tanner Clary commented on CALCITE-5554:
---------------------------------------

[~FrankZou] Changed from BUG -> IMPROVEMENT. The doc I attached was meant to 
show that DAYOFWEEK and DAYOFYEAR should be valid time units for the EXTRACT() 
and other similar functions. In terms of DAYOFWEEK and DAYOFYEAR being 
synonyms, DOW and DOY are abbreviations of these, as seen in this comment 
[here|https://github.com/apache/calcite/blob/b9c2099ea92a575084b55a206efc5dd341c0df62/druid/src/main/java/org/apache/calcite/adapter/druid/ExtractOperatorConversion.java#L38]

> Add DAYOFWEEK and DAYOFYEAR as valid synonyms of DOW, DOY
> ---------------------------------------------------------
>
>                 Key: CALCITE-5554
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5554
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Tanner Clary
>            Assignee: Tanner Clary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, a query such as: {{EXTRACT(DAYOFWEEK FROM DATE '2008-12-25');}} is 
> invalid while {{EXTRACT(DOW FROM DATE '2008-12-25')}} is acceptable. BigQuery 
> (and perhaps other dialects) accept the non-abbreviated version as a valid 
> time unit. After this change, DAYOFWEEK and DAYOFYEAR would both be synonyms 
> of DOW and DOY, respectively. 
> [Relevant BigQuery 
> Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#extract]
> Any comments, questions, or suggestions for the linked PR are highly 
> appreciated. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to