[ https://issues.apache.org/jira/browse/CALCITE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698129#comment-17698129 ]
Tanner Clary commented on CALCITE-5554: --------------------------------------- [~julianhyde] I adjusted the tests, many of them passed but there were still some failing that I left as-is. Let me know if there's anything else. > Add DAYOFWEEK and DAYOFYEAR as valid synonyms of DOW, DOY > --------------------------------------------------------- > > Key: CALCITE-5554 > URL: https://issues.apache.org/jira/browse/CALCITE-5554 > Project: Calcite > Issue Type: Improvement > Reporter: Tanner Clary > Assignee: Tanner Clary > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Currently, a query such as: {{EXTRACT(DAYOFWEEK FROM DATE '2008-12-25');}} is > invalid while {{EXTRACT(DOW FROM DATE '2008-12-25')}} is acceptable. BigQuery > (and perhaps other dialects) accept the non-abbreviated version as a valid > time unit. After this change, DAYOFWEEK and DAYOFYEAR would both be synonyms > of DOW and DOY, respectively. > [Relevant BigQuery > Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#extract] > Any comments, questions, or suggestions for the linked PR are highly > appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)