[ 
https://issues.apache.org/jira/browse/CALCITE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752021#comment-17752021
 ] 

LakeShen commented on CALCITE-5906:
-----------------------------------

Because of the TableSample percentage is float datatype, like this :
!image-2023-08-08-20-16-27-188.png|width=322,height=133!

When I tried to transform Sample to TABLESAMPLE  SqlCall,it shows imprecise 
precision,like this :
!image-2023-08-08-20-19-01-269.png|width=516,height=114!

I want to change the TableSample percentage to the type of precise 
precision,such as bigdecimal,could anyone else give me some advice?

> RelToSqlConverter throw AssertionError when RelNode tree has the Sample 
> RelNode
> -------------------------------------------------------------------------------
>
>                 Key: CALCITE-5906
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5906
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: LakeShen
>            Priority: Major
>             Fix For: 1.36.0
>
>         Attachments: image-2023-08-08-20-16-27-188.png, 
> image-2023-08-08-20-19-01-269.png
>
>
> Currently in the RelToSqlConverter class, there is no visit method to handle 
> the Sample RelNode.If a SQL plan has Sample RelNode, RelToSqlConverter will 
> throw a AssertionError like this:
> {code:java}
>  java.lang.AssertionError: Need to implement 
> org.apache.calcite.rel.core.Sample
> {code}
> This will cause the Sample RelNode plan to fail to translate to the 
> corresponding dialect.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to