[ https://issues.apache.org/jira/browse/CALCITE-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763238#comment-17763238 ]
Mihai Budiu commented on CALCITE-5986: -------------------------------------- {code:java} FLOAT(PrecScale.NO_NO, false, Types.FLOAT, SqlTypeFamily.NUMERIC), REAL(PrecScale.NO_NO, false, Types.REAL, SqlTypeFamily.NUMERIC), DOUBLE(PrecScale.NO_NO, false, Types.DOUBLE, SqlTypeFamily.NUMERIC), {code} This leads to at least one bug, in RelToSqlConverter FP literals are emitted as DECIMAL literals. > The SqlTypeFamily for FP types is incorrect > ------------------------------------------- > > Key: CALCITE-5986 > URL: https://issues.apache.org/jira/browse/CALCITE-5986 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.35.0 > Reporter: Mihai Budiu > Priority: Minor > > In SqlTypeFamily we have this code: > {code:java} > private static final Map<Integer, SqlTypeFamily> JDBC_TYPE_TO_FAMILY = > ... > .put(Types.FLOAT, NUMERIC) > .put(Types.REAL, NUMERIC) > .put(Types.DOUBLE, NUMERIC) > {code} > But it looks to me like the type family should be APPROXIMATE_NUMERIC. > This impacts the way RelToSqlConverter works, for instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)