[
https://issues.apache.org/jira/browse/CALCITE-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763245#comment-17763245
]
Julian Hyde commented on CALCITE-5986:
--------------------------------------
Probably would have been better if {{SqlTypeName.FLOAT.getFamily()}} (etc.)
returned {{APPROXIMATE_NUMERIC}} rather than {{NUMERIC}}. But changing it now
would probably have huge impact.
The bug here seems to be that the JDBC adapter generates the wrong literal for
{{FLOAT}} etc. Let's work on fixing that bug.
> The SqlTypeFamily for FP types is incorrect
> -------------------------------------------
>
> Key: CALCITE-5986
> URL: https://issues.apache.org/jira/browse/CALCITE-5986
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Mihai Budiu
> Priority: Minor
>
> In SqlTypeFamily we have this code:
> {code:java}
> private static final Map<Integer, SqlTypeFamily> JDBC_TYPE_TO_FAMILY =
> ...
> .put(Types.FLOAT, NUMERIC)
> .put(Types.REAL, NUMERIC)
> .put(Types.DOUBLE, NUMERIC)
> {code}
> But it looks to me like the type family should be APPROXIMATE_NUMERIC.
> This impacts the way RelToSqlConverter works, for instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
