[ 
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558972#comment-14558972
 ] 

YeongWei commented on CALCITE-705:
----------------------------------

Hi [~julianhyde],

I have attempted some preliminary implementation on my local. However below are 
a few items that I may need your guidance,

1. The ResultSet with "ROWCOUNT=<int>" is only available after the call of 
callback.execute within CalciteMetaImpl#prepareAndExecute. Therefore at the 
point of callback.assign, we would not have the value for updateCount. I am 
looking at if the execution sequence for the Meta.PrepareCallback needs to be 
altered?

2. To have CalciteMetaImpl to identify if the execution is a DML or Query, I 
intend to introduce say CalciteSignature#isDml which can be facilitated during 
the CalcitePrepareImpl#prepare2_ but that would be mean to overload the 
constructor CalciteSignature, do you think this may be beneficial in the long 
run, say when DDL comes into the picture?

Let me know what do you think.

Thank you very much!

> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to