[ 
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559812#comment-14559812
 ] 

Julian Hyde commented on CALCITE-705:
-------------------------------------

Regarding 1. PrepareCallback#assign is only to assign the prepare result. I 
think you should keep it at the same place in the execution sequence. But if 
ExecuteResult (created from the results of executing) contains a row count, 
that should supersede.

Regarding 2. Makes sense. But can you generalize a bit, and put {code}enum 
StatementType {
  SELECT, INSERT, UPDATE, DELETE, UPSERT, MERGE, OTHER_DML,
  CREATE, DROP, ALTER, OTHER_DDL, CALL,
} {code} in Avatica? Add an overloaded constructor to Meta.Signature and 
CalciteSignature, and mark the previous constructor deprecated.

> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to