[
https://issues.apache.org/jira/browse/CALCITE-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959664#comment-14959664
]
Jinfeng Ni commented on CALCITE-911:
------------------------------------
The first commit, [~jnadeau] changed CalciteSchema to abstract class, and
provided two version of extensions: caching and noncaching. The second commit
is change CalciteSchema to interface, and move code around abstract class and
Impl. The 3rd commit is adding a non-caching implementation, based on the
interface defined in the second commit.
The comment about return type of getTable(). I guess you are referring to
Jacque's commit, which happened before Calcite changes the return type from
Pair<String, Table> to TableEntry [1]. The second commit actually change it to
the TableEntry.
[1].
https://github.com/apache/incubator-calcite/commit/8b53dc49f49113daf12a355c5db18ccc248f4924
> Make CalciteSchema extendible for different implementation.
> -----------------------------------------------------------
>
> Key: CALCITE-911
> URL: https://issues.apache.org/jira/browse/CALCITE-911
> Project: Calcite
> Issue Type: Bug
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Fix For: 1.5.0-incubating
>
>
> CalciteSchema by default uses cache to store table, sub-schema, function.
> This would work perfectly for schema-based system, yet would create problem
> for Drill, which dynamically explore the schema on the fly during query
> execution.
> One solution is to refactor CalciteSchema and make it as an interface. The
> default implementation would still use the current implementation. Further,
> it would other system to extend the default behavior and make CalciteSchema
> works for Drill as well.
> Background information: The issue around CalciteSchema is one of the reasons
> that Drill has to use a forked version of Calcite. Hopefully, if we could
> resolve this issue, we are one step further to remove the forked Calcite in
> the near future.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
