[
https://issues.apache.org/jira/browse/CAMEL-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Babak Vahdat updated CAMEL-4796:
--------------------------------
Description:
This ticket aims to resolve the issues already mentioned in [1], but just to
name them ALL explicitly here:
- Removal of the unused imports
- Convert for loops to the enhanced one (supported since Java Tiger)
- Removal of the obsolete "super();" call by the Constructors (Since JDK 1.0
compilers already do it inside the byte-code for free!)
- Remove of all $NON-NLS$ tags
- Removal of the unnecessary casts
- Usage of the @Deprecated & @Override annotations where required
- Removal of unused private memebers: Types, Constructors, Fields and Methods
where applicable
- Remove the trailing whitespace on *all* lines, even on the empty ones
Add of missing serialVersionUID where required and default it to *1L* where
serialVersionUID has been already declared should be better postponed to the
major 3.0.x release as otherwise the backward-compatility would be broken on
the 2.x.y release branches.
If you can think of other possible clean-ups as well you may like to propose
for including, then please first better discuss it in [1] so that other
commiters can better/faster/easier react on it.
I'll provide the patches *exactly in the same order* as mentioned above.
Right now on the trunk my used IDE (eclipse) reports 1991 warnings!
[1] http://camel.465427.n5.nabble.com/DISCUSS-Trunk-Code-Cleanup-td5071594.html
was:
This ticket aims to resolve the issues mentioned in [1], just to name some of
them:
- organize imports
- avoid unnecessary cast
- add of missing serialVersionUID where required
If you can think of other possible clean-ups as well you may like to propose
for including, then please first better discuss it in [1] so that other
commiters can better/faster/easier react on it.
Right now on the trunk my used IDE (eclipse) reports 1991 warnings!
[1] http://camel.465427.n5.nabble.com/DISCUSS-Trunk-Code-Cleanup-td5071594.html
> Code Clean-Up
> -------------
>
> Key: CAMEL-4796
> URL: https://issues.apache.org/jira/browse/CAMEL-4796
> Project: Camel
> Issue Type: Improvement
> Affects Versions: 2.8.3
> Reporter: Babak Vahdat
> Assignee: Babak Vahdat
> Fix For: 2.9.1
>
> Attachments: CAMEL-4796-organize-imports-2.patch,
> CAMEL-4796-organize-imports.patch
>
>
> This ticket aims to resolve the issues already mentioned in [1], but just to
> name them ALL explicitly here:
> - Removal of the unused imports
> - Convert for loops to the enhanced one (supported since Java Tiger)
> - Removal of the obsolete "super();" call by the Constructors (Since JDK 1.0
> compilers already do it inside the byte-code for free!)
> - Remove of all $NON-NLS$ tags
> - Removal of the unnecessary casts
> - Usage of the @Deprecated & @Override annotations where required
> - Removal of unused private memebers: Types, Constructors, Fields and Methods
> where applicable
> - Remove the trailing whitespace on *all* lines, even on the empty ones
>
> Add of missing serialVersionUID where required and default it to *1L* where
> serialVersionUID has been already declared should be better postponed to the
> major 3.0.x release as otherwise the backward-compatility would be broken on
> the 2.x.y release branches.
> If you can think of other possible clean-ups as well you may like to propose
> for including, then please first better discuss it in [1] so that other
> commiters can better/faster/easier react on it.
> I'll provide the patches *exactly in the same order* as mentioned above.
> Right now on the trunk my used IDE (eclipse) reports 1991 warnings!
> [1]
> http://camel.465427.n5.nabble.com/DISCUSS-Trunk-Code-Cleanup-td5071594.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
