[ 
https://issues.apache.org/jira/browse/CAMEL-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266421#comment-13266421
 ] 

Babak Vahdat edited comment on CAMEL-5235 at 5/2/12 8:09 AM:
-------------------------------------------------------------

While trying to find some resources on the web describing what my *poor* 
english is talking about, I came along many of them but the best one was given 
through that *already dissappered real vendor* itself:

{quote}
Similarly, when closing chained streams, you only need to close the outermost 
stream class because the close() call is automatically trickled through all the 
chained classes; in the example above, you would simply call the close() method 
on the GZIPOutputStream class.
{quote}

When you look at the example there the inner most OutputStream is also a 
FileOutputStream, however there's no need of an explicit close call on that:

http://java.sun.com/developer/technicalArticles/Streams/ProgIOStreams/

There are plenty of other APIs having similar semantics (call-chaining) like 
when you close a JDBC Statement:

{quote}
Note:When a Statement object is closed, its current ResultSet object, if one 
exists, is also closed.
{quote}

http://docs.oracle.com/javase/6/docs/api/java/sql/Statement.html#close()

So why I still ask for your approval to get rid of those two obsolete static 
member classes.

                
      was (Author: bvahdat):
    While trying to find some resources on the web describing what my *poor* 
english is talking about, I came along many of them but the best one was given 
through that *already dissappered real vendor* itself:

{quote}
Similarly, when closing chained streams, you only need to close the outermost 
stream class because the close() call is automatically trickled through all the 
chained classes; in the example above, you would simply call the close() method 
on the GZIPOutputStream class.
{quote}

When you look at the example there the inner most OutputStream is also a 
FileOutputStream, however there's no need of an explicit close call on that:

http://java.sun.com/developer/technicalArticles/Streams/ProgIOStreams/

So why I still ask for your approval to get rid of those two obsolete static 
member classes.

                  
> Make sure to close file input stream when converting file to string to avoid 
> locking file on windows
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-5235
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5235
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.9.2
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.9.3, 2.10.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/File-Processor-Not-deleting-the-files-tp5670301.html
> Need to explicit close the file input/output streams to avoid the files to be 
> locked on windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to