[ 
https://issues.apache.org/jira/browse/CAMEL-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450443#comment-13450443
 ] 

Claus Ibsen commented on CAMEL-5563:
------------------------------------

Instead of graceful by default, we have decided to add a shutdownGraceful 
method instead. This gives end user to full power to chose what to use.

API documented in the bottom of this page
https://cwiki.apache.org/confluence/display/CAMEL/Threading+Model

This also avoids a slight API change in the 2.10 branch, which will be reverted.
                
> ExecutorServiceManager - Should shutdown thread pools less aggressively 
> ------------------------------------------------------------------------
>
>                 Key: CAMEL-5563
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5563
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.10.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.11.0, 2.10.2
>
>
> We have so far favored shutting down thread pools a bit too aggressively from 
> the start using shutdownNow. Instead we should favor shutdown, and allow the 
> pool a bit time to shutdown orderly, before we go aggressively by shutting 
> down now.
> We should also allow end users to configure a await termination timeout value 
> to control how long we wait to orderly shutdown.
> By default this value could be 5 seconds (not too high and not to low).
> Also we should consider allow to configure a log level, which logs the 
> in-flight threads which wasn't shutdown orderly. This can aid people to 
> identify these threads.
> By default we could log this at WARN level. Notice that over time these 
> threads may shutdown naturally when they complete, so its not a severe error. 
> This requires minder API additions to ExeuctorServiceManager. However it 
> ought to be worthy of being backported to the 2.10 branch IMHO

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to