[ https://issues.apache.org/jira/browse/CAMEL-19555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762749#comment-17762749 ]
Otavio Rodolfo Piske commented on CAMEL-19555: ---------------------------------------------- Hi, thanks for the heads up. Yes, that's OK. I just wanted to check if the issue was stale or not. Thanks! > camel-spring: ensure tests have assertions > ------------------------------------------ > > Key: CAMEL-19555 > URL: https://issues.apache.org/jira/browse/CAMEL-19555 > Project: Camel > Issue Type: Task > Components: camel-spring, camel-spring-ws, camel-spring-xml, tests > Affects Versions: 4.0.0 > Reporter: Otavio Rodolfo Piske > Priority: Minor > Labels: easy, help-wanted > > Some tests do not have assertions and that prevents us from fully > understanding what is a test failure and what is an error. In many cases, > these are tests that were originally written with older versions of JUnit in > mind (i.e: equal or older than v4), so they lack modernization. > > We should ensure every test has an assertion. The assertion does not, > necessarily, needs to be visible (i.e.: it can be called in a separate > method). > > When asserting that a piece of code does not throw an error, we should use > JUnit's 5 > [assertDoesNotThrow|https://junit.org/junit5/docs/5.8.2/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html#assertDoesNotThrow(org.junit.jupiter.api.function.Executable)] > (either the linked method or one of the others with different signatures). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)