[
https://issues.apache.org/jira/browse/CAMEL-20355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813728#comment-17813728
]
Otavio Rodolfo Piske commented on CAMEL-20355:
----------------------------------------------
There seems to exist a few more limitations in the current implementation, such
as the one reported on the mailing list (where a user needs the throttling
window to be higher than 1 second). I believe that should also be taken into
account.
IMHO, the easiest way would be to have the possibility to have both behaviors.
Something like "throttle().leakyBucket()..." and
"throttle().classic(maxRequestsPerPeriod).timePeriodMillis(1000)". Although
this is still a bit disruptive to users, adding "classic" is still easier than
trying and testing a different implementation.
> Throttle EIP: milliseconds not available anymore
> ------------------------------------------------
>
> Key: CAMEL-20355
> URL: https://issues.apache.org/jira/browse/CAMEL-20355
> Project: Camel
> Issue Type: Improvement
> Components: camel-k, camel-kamelet, documentation
> Affects Versions: 4.3.0
> Reporter: Raymond
> Priority: Minor
> Fix For: 4.x
>
>
> Recently, the Throttle EIP was changed. For example, in this issue:
> https://issues.apache.org/jira/browse/CAMEL-16099
> Now the option "{*}timePeriodMillis{*}" isn't available anymore:
> [https://camel.apache.org/components/next/eips/throttle-eip.html]
> This is also documented in the migration guide:
> [https://camel.apache.org/manual/camel-4x-upgrade-guide-4_3.html]
> However:
> 1. The option is still there in the examples of the latest documentation
> 2. The option is still there in the Kamelet catalog (4.3.0):
> [https://github.com/apache/camel-kamelets/blob/main/kamelets/throttle-action.kamelet.yaml]
> When loading the throttle from the Kamelet catalog, I got the following
> message:
> {code:java}
> could not load: kamelets/throttle-action.kamelet.yaml. Reason: Field:
> timePeriodMillis has already been configured as an expression
> in throttle-action.kamelet.yaml, line 67, column 29:
> timePeriodMillis: "{{timePeriod}}" {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
