[
https://issues.apache.org/jira/browse/CAMEL-23312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073369#comment-18073369
]
Pasquale Congiusti commented on CAMEL-23312:
--------------------------------------------
Thanks for the proposal. This feature is already covered by the Span Decorator,
see design doc [1]:
"The span decoration is a Camel specific way of decorating the different
components we handle with specific traces information. As an example, when
you’re using Kafka component, you will get automatically in the trace useful
configuration as the offset or the partition. We already have this mechanism in
place and we should make sure to have a clear documentation stating about this
particular feature."
In our case we should be able to add a tag in each specific abstract http and
messaging (or even at specific component level if required) to include the Kind
as a tag attached to the Span.
[1] https://github.com/apache/camel/blob/main/proposals/tracing.adoc
> Opentelemetry2: SpanLifecycleManager.create() missing SpanKind parameter
> causing incorrect span types
> -----------------------------------------------------------------------------------------------------
>
> Key: CAMEL-23312
> URL: https://issues.apache.org/jira/browse/CAMEL-23312
> Project: Camel
> Issue Type: Improvement
> Components: camel-opentelemetry
> Affects Versions: 4.18.0
> Reporter: Jiri Ondrusek
> Assignee: Jiri Ondrusek
> Priority: Major
> Fix For: 4.18.2, 4.20.0
>
>
> The SpanLifecycleManager.create() API lacks a SpanKind parameter:
> Span create(String spanName, Span parent, SpanContextPropagationExtractor
> extractor);
> This causes all camel-opentelemetry2 spans to default to INTERNAL instead
> of the
> correct CLIENT/SERVER/PRODUCER/CONSUMER types.
> Expected: HTTP client calls → SpanKind.CLIENT, server endpoints →
> SpanKind.SERVER
> Actual: All spans → SpanKind.INTERNAL
> The legacy camel-opentelemetry works around this by using custom methods
> like
> startSendingEventSpan() that accept org.apache.camel.tracing.SpanKind.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
