Andrea Cosentino created CAMEL-23581:
----------------------------------------
Summary: camel-elasticsearch + camel-opensearch - align Exchange
header constant names with Camel naming convention
Key: CAMEL-23581
URL: https://issues.apache.org/jira/browse/CAMEL-23581
Project: Camel
Issue Type: Improvement
Components: camel-elasticsearch, camel-opensearch
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
Fix For: 4.21.0
{{ElasticsearchConstants}} (and the mirror {{OpensearchConstants}}) expose
producer-read header constants with non-prefixed values:
* {{PARAM_OPERATION = "operation"}} - dispatch (Index / Update / Delete /
DeleteIndex / Search / MultiSearch / Bulk / Ping / Exists / GetById)
* {{PARAM_INDEX_NAME = "indexName"}}, {{PARAM_INDEX_ID = "indexId"}} - target
index and document
* {{PARAM_DOCUMENT_CLASS = "documentClass"}} - deserialisation class
* {{PARAM_DOCUMENT_MODE = "enableDocumentOnlyMode"}},
{{PARAM_WAIT_FOR_ACTIVE_SHARDS}}, {{PARAM_SCROLL}},
{{PARAM_SCROLL_KEEP_ALIVE_MS}}, {{PARAM_SIZE}}, {{PARAM_FROM}}
Rename to {{CamelElasticsearch<Name>}} / {{CamelOpensearch<Name>}}. Bundle the
change because the two components are intentional copies.
h3. Fix shape
Rename the *string value* of each producer-read header constant to
{{Camel<Component><Name>}}; keep the Java field name unchanged so routes that
reference the constants symbolically continue to compile and run. Update tests
that use the literal string values; regenerate component catalog JSON and docs;
add an upgrade-guide entry in {{camel-4x-upgrade-guide-4_21.adoc}} (and
matching 4_18 / 4_14 for backports where the component existed in those
branches).
h3. References
* Tracker: CAMEL-23577
* Precedent (rename pattern): CAMEL-23526 (camel-cxf)
* Alternative pattern (HeaderFilterStrategy approach): CAMEL-23532
(camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
