Andrea Cosentino created CAMEL-23597:
----------------------------------------
Summary: camel-solr - align Exchange header prefix constants with
Camel naming convention
Key: CAMEL-23597
URL: https://issues.apache.org/jira/browse/CAMEL-23597
Project: Camel
Issue Type: Improvement
Components: camel-solr
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
Two Exchange-header prefix constants in camel-solr still use a non-Camel
namespace and were missed during the broader cleanup in CAMEL-21697:
- SolrConstants.HEADER_FIELD_PREFIX = "SolrField."
- SolrConstants.HEADER_PARAM_PREFIX = "SolrParam."
Other Exchange-header constants in the same file were renamed to the
CamelSolrXxx convention in CAMEL-21697 (PARAM_OPERATION, PARAM_COLLECTION,
PARAM_REQUEST_HANDLER, PARAM_QUERY_STRING, PARAM_SIZE, PARAM_FROM,
PARAM_SOLR_PARAMS, PARAM_DELETE_BY_QUERY), but the two prefix constants above
were not. As a result they fall outside the CAMEL_FILTER_STARTS_WITH =
{"Camel", "camel"} set used by the standard HeaderFilterStrategy
implementations, so they are not stripped by the default Camel/HTTP header
filtering when an exchange flows between transports.
This is the same alignment work done for sibling components in CAMEL-23506
(camel-aws2-sqs / camel-aws2-sns), CAMEL-23508, CAMEL-23510, CAMEL-23515,
CAMEL-23516, CAMEL-23522 (camel-mail), CAMEL-23526 (camel-cxf), and CAMEL-23532
(camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy).
Proposed change:
- SolrConstants.HEADER_FIELD_PREFIX value: "SolrField." -> "CamelSolrField."
- SolrConstants.HEADER_PARAM_PREFIX value: "SolrParam." -> "CamelSolrParam."
Keep the Java field names (HEADER_FIELD_PREFIX, HEADER_PARAM_PREFIX) unchanged
so route and test code that references the constants symbolically continues to
work; routes that set headers by their literal string value will need to be
updated. Update the component documentation (solr-component.adoc), the existing
integration tests under camel-solr that use the literal header names, and add
upgrade-guide entries for 4.21 (main), 4.18 and 4.14 noting the rename.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
