[
https://issues.apache.org/jira/browse/CAMEL-26093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130865#comment-18130865
]
Claus Ibsen commented on CAMEL-26093:
-------------------------------------
camel-azure-eventgrid has the same gap: it is not in the list of camel-azure
modules of MojoHelper since it was added (CAMEL-20552, 4.17.0), so the catalog,
Camel CLI and the DSLs do not know it either, and the YAML example of its page
put steps beside from. PR [#28349|https://github.com/apache/camel/pull/28349]
now registers both components, in one commit each. They are the only component
modules of a parent folder that MojoHelper misses.
_Claude Code on behalf of davsclaus_
> camel-aws-parameter-store and camel-azure-eventgrid are not in the catalog,
> and the YAML examples of their pages do not load
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-26093
> URL: https://issues.apache.org/jira/browse/CAMEL-26093
> Project: Camel
> Issue Type: Bug
> Components: camel-aws2, camel-azure, camel-catalog
> Affects Versions: 4.18.0, 4.22.0, 4.23.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Major
> Fix For: 4.24.0
>
>
> Found while adding the catalog body types of aws-parameter-store
> (CAMEL-24961).
> h4. 1. The component is not in the catalog
> camel-aws-parameter-store is missing from the list of camel-aws modules in
> {{MojoHelper.getComponentPath}} of camel-package-maven-plugin (main
> ed3d719b379c, lines 128-150), since the component was added (CAMEL-22819,
> 4.18.0). So the catalog has no aws-parameter-store.json and no page, and
> everything that reads the catalog misses the component:
> * {{camel run}} of a route with {{aws-parameter-store:}} fails with "cannot
> find component with name aws-parameter-store" unless the dependency is given
> by hand;
> * the Endpoint DSL and the component DSL have no builder for it;
> * the build checks of the doc examples, which read the pages in the catalog,
> never ran on its page.
> The same happened to azure-servicebus in CAMEL-17372.
> *Proposed change*: add the module to MojoHelper and regenerate the catalog
> and the DSLs.
> h4. 2. The YAML examples of the page do not load
> Nine of the YAML examples put {{steps:}} beside {{from:}} instead of under it
> ({{aws-parameter-store-component.adoc}}, lines 347, 393, 443, 500, 557, 608,
> 654, 700 and 746). The YAML DSL has no {{steps}} key on a route, so these
> routes fail to load. The examples before line 300 are right.
> h4. 3. No operation fails with a NullPointerException
> The operation option has no default, and with no
> CamelAwsParameterStoreOperation header, {{switch
> (determineOperation(exchange))}} ({{ParameterStoreProducer}}, main
> ed3d719b379c, line 74) fails with {{NullPointerException: Cannot invoke
> "...ordinal()" because the return value of "...determineOperation(...)" is
> null}}. Checked on 4.24.0-SNAPSHOT with {{camel run}} against the AWS
> emulator of {{camel infra run aws}}.
> *Proposed change*: fail with a message that says to set the operation option
> or header, as aws2-kms does ("Operation must be specified").
> h4. 4. getParameters and deleteParameters do not trim the names
> The {{CamelAwsParameterStoreNames}} header is split on commas without
> trimming (lines 174 and 323), so {{/a, /b}} asks for " /b". Checked on
> 4.24.0-SNAPSHOT with {{camel run}} against the AWS emulator of {{camel infra
> run aws}}: getParameters gives the second parameter in {{invalidParameters}}
> as {{[ /bt/bytes]}}, and the exchange does not fail.
> h4. Also read in the code, not run
> * The page does not say that getParameter gives the value as the body, nor
> that the CamelAwsParameterStoreValue header wins over the body for
> putParameter (CAMEL-24363).
> _Claude Code on behalf of davsclaus_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
