[ 
https://issues.apache.org/jira/browse/CAMEL-26061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131151#comment-18131151
 ] 

Claus Ibsen commented on CAMEL-26061:
-------------------------------------

Fixed in PR https://github.com/apache/camel/pull/28373

_Claude Code on behalf of davsclaus_

> camel-micrometer - the docs say a warning is logged where the exchange fails
> ----------------------------------------------------------------------------
>
>                 Key: CAMEL-26061
>                 URL: https://issues.apache.org/jira/browse/CAMEL-26061
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-micrometer
>    Affects Versions: 4.18.0, 4.22.0, 4.23.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 4.24.0
>
>
> Found while adding the catalog body types of micrometer (CAMEL-24961), 
> checked with {{camel run}}. The body is fine; the docs say something else 
> than the code about failures.
> h4. 1. A failure fails the exchange, but the docs say a warning is logged
> The producer sets an exception on the exchange 
> ({{AbstractMicrometerProducer}}, main 5aac7df76b83, line 77), but the docs 
> say "Micrometer endpoint will catch all exceptions and write log entry using 
> level warn." ({{micrometer-component.adoc}}, line 152), and that a warning is 
> logged for no value (line 464) and for no or an invalid timer action (lines 
> 612-615). Checked on 4.24.0-SNAPSHOT with {{camel run}}: a summary value that 
> is not a number failed the exchange with a TypeConversionException to Double, 
> and an invalid CamelMetricsTimerAction one with a TypeConversionException to 
> MicrometerTimerAction; a missing value records nothing and logs nothing.
> h4. Also read in the code, not run
> * The CamelMetricsHistogramValue header is documented as a long 
> ({{MicrometerConstants}}, line 30) and read as a Double 
> ({{DistributionSummaryProducer}}, line 41).
> * metricsType is required in the catalog, but a URI without it is a counter.
> _Claude Code on behalf of davsclaus_



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to